Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cool T-Shirts Summary / Rubric Score #1

Open
karl-project-review opened this issue Jul 5, 2018 · 0 comments
Open

Cool T-Shirts Summary / Rubric Score #1

karl-project-review opened this issue Jul 5, 2018 · 0 comments

Comments

@karl-project-review
Copy link

Rubric Score

Criteria 1: Report: Are conclusions clear and supported by evidence in all eight answers?

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): All of your conclusions are well-explained and supported by evidence, with the possible exception of the second point in your optimization recommendations. It suggests we look at regional news and blog articles as with suggestion (1), but since all of the newspapers and websites listed in (1) are national papers and websites, it isn't clear what you have in mind with this. How small of newspapers and blogs are you suggesting they advertise in, and what kind of location information do you suggest collecting on the purchasers? Also, is there something in the SQL database we have that suggests we need to do something like this, or is this just an idea that you think would be helpful? And why did you suggest focusing on the New York area in particular, as opposed to any other region? Be sure to have adequate support for all aspects of recommendations like this.

Criteria 2: Query Accuracy: Do queries do what they were supposed to do?

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): All of your queries perform as advertised. Well done!

Criteria 3: Query Formatting

  • Score Level: 3/4 (Meets Expectations)
  • Comment(s): Your SQL code adheres to most of the style guidelines, but there are issues with the spacing/indentation levels. FROM statements should always be at the same indentation level as their corresponding SELECT statements (like they are in the queries for 1.1 - 1.3) as opposed to being either more or less indented (like they are in lines 27-41, 49-63, and 78-92). The same is true for JOIN, GROUP BY, and ORDER BY statements. Also, ON and AND statements should be indented one level further than JOIN statements, not one level less. Also, while most of the time you put every column being selected on a separate line, on line 11 there are two on the same line. Make sure to adhere to these guidelines consistently.

Criteria 4: Understanding underlying concepts and terminology

  • Score Level: 4/4 (Exceeds Expectations)
  • Comment(s): You use the correct terminology throughout and demonstrate an understanding of touch attribution and its significance. Good work!

Overall Score: 15/16 (Exceeds Expectations)

Great work! Your queries work like they are supposed to and you demonstrated an understanding on the underlying concepts. I would encourage you to focus on your spacing and indentation levels in your future projects, as having your code lined up properly will make it quicker and easier to read through and understand. Also, I would encourage you to think more about how to expand upon and clarify your suggestion to focus on regional advertising, as that could well be a useful suggestion and putting in the time to figure out how to give a stronger pitch for it could be a worthwhile exercise. Again, well done with this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant