Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #99

Open
jjren opened this issue Jul 10, 2020 · 2 comments
Open

Documentation #99

jjren opened this issue Jul 10, 2020 · 2 comments
Assignees

Comments

@jjren
Copy link
Collaborator

jjren commented Jul 10, 2020

I think it is time to gradually improve the documentation of Renormalizer and make it more accessible to the community.
Let's begin with the module-level docs first!

@liwt31
Copy link
Collaborator

liwt31 commented Jul 10, 2020

While this is certainly a gradual process, the mlist module is facing a major update (#100) and I recommend postponing the documentation of this part.

@liwt31
Copy link
Collaborator

liwt31 commented Jul 14, 2020

For a more friendly user interface to the community, some of the interfaces require unification. To name a few:

  • In MatrixProduct, bond_dims and pbond_list are two relevant properties that have quite different names. pbond_list is also used in MolList2.
  • In MatrixProduct, the same as above for check_left_canonical and is_left_canon.
  • In MatrixProduct, set_threshold and property setter threshold are duplicate.
  • Mps.full_wfn and Mpo.full_operator are better renamed to to_dense.
  • In Phonon, n_phys_dim in __init__ and the propertypbond nlevels.
  • Return value is sometimes Quantity and sometimes float. I suggest for all return value use float while for input value Quantity is preferred.
  • ...

Also, some interfaces seem obsolete and maybe they should be removed:

  • Mpo.from_mp
  • MatrixProduct.build_none_qn
  • MatrixProduct.clear_qn
  • ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants