Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week 1 Project Feedback #9

Open
BCallumCarr opened this issue Jul 9, 2018 · 0 comments
Open

Week 1 Project Feedback #9

BCallumCarr opened this issue Jul 9, 2018 · 0 comments

Comments

@BCallumCarr
Copy link

Some pretty cool graphs here guys :) Just make sure to check your code for errors before your final push to GitHub (think I only found one), and remember to err on the side of commenting too much rather than too little! Also just remember that if you don't store your scraped data separately to do exploratory stuff on it then anyone using your code would have to scrape all over again. Lastly, if you reference data files that aren't on the repo then we won't be able to see it :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant