Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.11.4 performance improvement is also a regression #46

Open
JulianKingman opened this issue May 15, 2020 · 2 comments
Open

0.11.4 performance improvement is also a regression #46

JulianKingman opened this issue May 15, 2020 · 2 comments

Comments

@JulianKingman
Copy link

In my app I have a light and dark mode, and when that changes, I pass in an updated theme object to StyleProvider, thus re-rendering all the connected UI elements.

Unfortunately, this was broken by this commit: 5b1638e

I quite like being able to update the theme with dynamic values, and would rather handle the performance optimization myself. If that's not possible, then a forceUpdate function or something would be great.

@JulianKingman
Copy link
Author

Ah, it's actually because of a shallow equals here: 5b1638e#diff-58875160ad594f84c51eba08adcd2df7R23

Suggest using _.isEqual

@JulianKingman
Copy link
Author

Something else is preventing the UI updates, maybe in connectStyle? Can't figure it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant