Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windsock: thread limiting #6

Open
rukai opened this issue May 8, 2023 · 0 comments
Open

windsock: thread limiting #6

rukai opened this issue May 8, 2023 · 0 comments
Assignees

Comments

@rukai
Copy link
Member

rukai commented May 8, 2023

When benching on a single machine we need to finely control the number of threads used by the services spun up by windsock. This includes the bench itself, shotover and the DB.
If services are sharing cores it will give less consistent results as a service performing more work will slow down other services.
In a realistic production use case these services will be running on machines with more than just one core, so we should use as many cores as we have available in order to create a realistic scenario.
Additionally we will get more useful results if we always ensure shotover is the bottleneck, that way we will actually be able to measure changes to shotovers performance.

To achieve this, there should be hardcoded logic per Bench implementation that derives the core counts per service from the number of cores on the machine it runs on.

@rukai rukai self-assigned this May 10, 2023
@conorbros conorbros transferred this issue from shotover/shotover-proxy Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant