Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster - handle broker configured connection timeouts #1733

Open
rukai opened this issue Aug 22, 2024 · 0 comments
Open

KafkaSinkCluster - handle broker configured connection timeouts #1733

rukai opened this issue Aug 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rukai
Copy link
Member

rukai commented Aug 22, 2024

pulled out of #1728

  • sending requests will reset the timeout counter, in the case where the connection has timed out when we send the request there should be no pending requests so we can just open it (with a sanity check on number of pending requests)
    • oh wait we cant do this because a message might still pass through on connection closed... Maybe we need a ConnectionError::OtherSideClosedCleanly? Maybe we can use the read disconnect? Need to do testing on kafka itself to determine whether it sends TCP FIN or TCP RST when a connection times out.
  • receiving requests will not reset the timeout counter, but we can just avoid checking for requests when a connection has no pending requests.
@rukai rukai added the bug Something isn't working label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant