Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port redis pubsub tests to fred #1537

Open
rukai opened this issue Mar 19, 2024 · 0 comments
Open

Port redis pubsub tests to fred #1537

rukai opened this issue Mar 19, 2024 · 0 comments
Labels
cleanup-internal Any cleanup that is not cleanup-api

Comments

@rukai
Copy link
Member

rukai commented Mar 19, 2024

In order to update the redis dependency used by our test suite we will need to migrate the pubsub tests to use a different redis client.
This is because the new redis crate changed its pubsub support to disallow converting a connection between a pubsub connection and a regular connection.
This is a very reasonable position for them to take since the redis pubsub protocol is very silly and this lets them sidestep a bunch of its silliness.

However its a bit annoying for us since we need to test the cornercases of this silliness.

From a quick look at fred it looks like they do support pubsub/nonpubsub on the same connection:
https://docs.rs/fred/latest/fred/clients/struct.RedisClient.html#method.message_rx
https://docs.rs/fred/latest/fred/clients/struct.RedisClient.html#method.subscribe

We should be able to maintain some of our existing pubsub tests with redis crate and then add extra tests with fred.

If fred doesnt work out we should consider writing a super minimal client on top of redis-protocol, shouldnt be too bad.

@rukai rukai added the cleanup-internal Any cleanup that is not cleanup-api label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-internal Any cleanup that is not cleanup-api
Projects
None yet
Development

No branches or pull requests

1 participant