Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ratio should be subsumed by freq control coefficients. #222

Open
dpwe opened this issue Sep 24, 2024 · 0 comments
Open

ratio should be subsumed by freq control coefficients. #222

dpwe opened this issue Sep 24, 2024 · 0 comments

Comments

@dpwe
Copy link
Collaborator

dpwe commented Sep 24, 2024

The ratio argument sets the osc frequency to some factor times a "base frequency". This is used in FM tones, and is based on the parameter of the same name in the classic DX7 algorithms.

In fact, it's just a special case of the ControlCoefficients. ratio=0.5 means that the oscillator frequency is half the note frequency, which in other situations we'd achieve with freq='130.8,1', i.e. frequency tracking the note, but relative to C3, so an octave below (0.5x the frequency).

We really ought to change over to using freq coefficients, since using ratio diminishes the payoff of getting to grips with ControlCoefficients. At the moment I believe the ratio mechanism overrides the normal freq calculation for FM oscs, and we presumably don't currently propagate the base osc note to the algorithm oscs. So we'd need to fix those too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant