Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility issue with split Panel #21

Closed
paulGeoghegan opened this issue Jun 23, 2024 · 5 comments
Closed

Accessibility issue with split Panel #21

paulGeoghegan opened this issue Jun 23, 2024 · 5 comments
Labels
bug Something isn't working NVDA NVDA specific issues screenreader

Comments

@paulGeoghegan
Copy link

Describe the bug

A bug is a demonstrable problem caused by code in the library. Please provide a clear and concise description of what the bug is here.
You can't re-size the panels if you are using a screen reader.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://backers.webawesome.com/docs/components/split-panel
  2. try to interact with the resize separator controls while using a screen reader in my case NVDA
  3. Nothing happens

Browser / OS

  • OS: Windows
  • Browser: Firefox
  • Browser version: 127.0.1
  • Screen Reader: NVDA

Additional information

Provide any additional information about the bug here.
Honestly this isn't the biggest deal given that it's unlikely to matter to a screen reader user but it would be great even for being able to test things or if you are showing something to someone.

PS the templates definitely help.

@paulGeoghegan paulGeoghegan added the bug Something isn't working label Jun 23, 2024
@claviska claviska added screenreader NVDA NVDA specific issues labels Jun 24, 2024
@claviska
Copy link
Member

I know this was filed under NVDA, but it works using Safari + VoiceOver with the CMD modifier and arrow keys.

@paulGeoghegan can you tell us what key's your using to resize so we can reproduce this in NVDA?

@paulGeoghegan
Copy link
Author

@claviska ah actually I can re-size it if I hold the alt key and then use the arrows or home/end keys. It just wasn't entirely obvious how to use it but maybe that's just me. I feel like it would maybe good to add some kind of hint to let people know because I personally haven't ever had to change a value like that but again maybe it's just me.

@claviska
Copy link
Member

No worries. I'm not as familiar with key combos in NVDA.

Side note: I noticed ARIA APG has a pattern for this now, so maybe we can align to it soon. https://www.w3.org/WAI/ARIA/apg/patterns/windowsplitter/

@paulGeoghegan
Copy link
Author

@claviska I definitely think that would help.

@claviska
Copy link
Member

It looks like we already align with the keyboard shortcuts mentioned here except for this one:

  • Enter: If the primary pane is not collapsed, collapses the pane. If the pane is collapsed, restores the splitter to its previous position.

I've added this to Shoelace and Web Awesome. It will be available in the next release of both libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NVDA NVDA specific issues screenreader
Projects
None yet
Development

No branches or pull requests

2 participants