Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are currently failing on Windows #1066

Closed
claviska opened this issue Dec 9, 2022 · 1 comment
Closed

Tests are currently failing on Windows #1066

claviska opened this issue Dec 9, 2022 · 1 comment
Labels
good first issue This bug or task is a good first issue for new contributors. help wanted Ready for a contributor to tackle. testing Everything related to testing.

Comments

@claviska
Copy link
Member

claviska commented Dec 9, 2022

To repro, run the following on a Windows machine not using WSL:

npm install @shoelace-style/shoelace
cd shoelace
npm i
npm run build
npm run test

This was reported by a user and also fails on my Windows machine. Apologies, but I don't have the error handy to paste here.

@claviska claviska added help wanted Ready for a contributor to tackle. testing Everything related to testing. good first issue This bug or task is a good first issue for new contributors. labels Dec 9, 2022
@claviska claviska added this to the 2.0 (stable) milestone Dec 9, 2022
@claviska
Copy link
Member Author

claviska commented Jan 9, 2023

After searching the error message, this comment suggested it was a problem with the source-map package on Node 18+. In short, the package differentiates between Node and browsers by detecting window.fetch, which was introduced in Node 18, causing the breakage.

This was fixed in 0.7.4, so adding source-map to devDependencies using that version or higher seems to do the trick on Windows. I'm not sure why macOS, Linux, et al were unaffected.

claviska added a commit that referenced this issue Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This bug or task is a good first issue for new contributors. help wanted Ready for a contributor to tackle. testing Everything related to testing.
Projects
None yet
Development

No branches or pull requests

1 participant