Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShipwrightBuild immediately reports "Ready=true" status #50

Open
adambkaplan opened this issue Dec 21, 2021 · 1 comment
Open

ShipwrightBuild immediately reports "Ready=true" status #50

adambkaplan opened this issue Dec 21, 2021 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@adambkaplan
Copy link
Member

Description

If a ShipwrightBuild object is created after Tekton has been installed, the status condition reports "Read=true" right away.

Expected Behavior

ShipwrightBuild doesn't report the Ready=true status until the underlying build controller deployment reports itself ready.

Actual Behavior

The ShipwrightBuild object reports itself ready immediately.

/kind bug

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 21, 2021
@adambkaplan adambkaplan added this to the Backlog milestone Mar 9, 2022
@adambkaplan
Copy link
Member Author

Note - ShipwrightBuild's Ready condition should reflect the aggregated state of Shipwright Build's system. For now that's just the build controller deployment, but in the future this could include other items directly related to builds (ex - validating webhook).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

1 participant