Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace replacements with name_template in GoReleaser configuration #233

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

HeavyWombat
Copy link
Contributor

@HeavyWombat HeavyWombat commented Mar 14, 2024

Changes

Bump to goreleaser/goreleaser-action@v5.

Remove pinned GoReleaser version.

Replaced deprecated replacements with a name_template to achieve the same output:

  • cli_0.12.0_windows_x86_64.tar.gz (architecture name changed from amd64 to x86_64)
  • cli_0.12.0_macOS_arm64.tar.gz (operating system name changed from darwin to macOS)
  • cli_0.12.0_linux_x86_64.tar.gz
  • cli_0.12.0_macOS_x86_64.tar.gz
  • cli_0.12.0_linux_arm64.tar.gz
  • cli_0.12.0_windows_arm64.tar.gz

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Bump to `goreleaser/goreleaser-action@v5`.

Remove pinned GoReleaser version.

Replaced deprecated `replacements` with a `name_template` to achieve the same output:
cli_0.12.0_windows_x86_64.tar.gz
cli_0.12.0_macOS_arm64.tar.gz
cli_0.12.0_linux_x86_64.tar.gz
cli_0.12.0_macOS_x86_64.tar.gz
cli_0.12.0_linux_arm64.tar.gz
cli_0.12.0_windows_arm64.tar.gz

Signed-off-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 14, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2024
@HeavyWombat HeavyWombat mentioned this pull request Mar 14, 2024
4 tasks
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 14, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2024
Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4d2c4c9 into main Mar 14, 2024
9 checks passed
@HeavyWombat HeavyWombat deleted the fix/goreleaser-config branch March 15, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants