bump kubernetes version and other dependencies #198
Conversation
|
/kind dependencies |
|
@coreydaley: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind dependency-change |
openshift-ci
bot
added
the
kind/dependency-change
|
/assign @SaschaSchwarze0 @qu1queee @adambkaplan ptal |
|
@coreydaley: GitHub didn't allow me to assign the following users: ptal. Note that only shipwright-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/shp/cmd/buildrun/logs.go
Outdated
| ctx := context.Background() | ||
| err = wait.PollUntilContextTimeout(ctx, 1*time.Second, 10*time.Second, true, func(context.Context) (done bool, err error) { |
There was a problem hiding this comment.
Curious, couldn't we use c.cmd.Context() instead of a new background context or the PollUntilContextTimeout call?
There was a problem hiding this comment.
Fixed in next push
| @@ -178,7 +178,7 @@ func TestStreamBuildRunFollowLogs(t *testing.T) { | |||
| cmd.Cmd().ExecuteC() | |||
| pm := genericclioptions.NewConfigFlags(true) | |||
| if len(test.to) > 0 { | |||
| pm.Timeout = &test.to | |||
| *pm.Timeout = test.to | |||
There was a problem hiding this comment.
Me, tired, trying to do pointer arithmetic.
There was a problem hiding this comment.
This is what prompted the change:
> make sanity-check 2023-08-23-bump-dependencies
golangci-lint run
pkg/shp/cmd/buildrun/logs_test.go:181:17: G601: Implicit memory aliasing in for loop. (gosec)
pm.Timeout = &test.to
^
make: *** [sanity-check] Error 1
If i interpret it correctly, memory addresses are reused in for loops.
| k8s.io/api v0.27.3 | ||
| k8s.io/apimachinery v0.27.3 | ||
| k8s.io/cli-runtime v0.27.3 | ||
| k8s.io/client-go v0.27.3 |
There was a problem hiding this comment.
What was our plan here? Shouldn't we keep that in sync with what we have in Shipwright Build, i. e. v0.25-ish?
There was a problem hiding this comment.
I think we are still working on deciding what version to use, this was just the repository that I picked to try the upgrade with. I would like to use v0.27.3 since it won't go EOM as soon and it aligns with the version that we are using in OpenShift.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Bump kubernetes version and other associated dependencies
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes