-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file listing for bundle unpack and Git clone #1702
Conversation
f531378
to
fd07cc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some questions.
fd07cc9
to
186faec
Compare
186faec
to
18a9091
Compare
Add flag to enable to print a file listing when the unpacking or cloning of a source bundle is complete. Signed-off-by: Matthias Diester <[email protected]>
18a9091
to
8afa9c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow-up from #1702 to add the total size in bytes of all files and the total number of files to the file listing so that its immediately visible. Signed-off-by: Matthias Diester <[email protected]>
Changes
Add flag to enable to print a file listing when the unpacking of a source bundle or Git clone is complete.
Output looks like this:
/kind feature
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes