Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dynamic fillValue values #103

Open
micheleb opened this issue Aug 12, 2024 · 3 comments · May be fixed by #104
Open

Support dynamic fillValue values #103

micheleb opened this issue Aug 12, 2024 · 3 comments · May be fixed by #104

Comments

@micheleb
Copy link

Hey there! 👋🏻

I had the same issue as #88: providing dynamic values for fillValue does not update the position of the Cap component.

I patched the dependency locally and it works as expected, will create a PR right away. Sorry but I don't have the time to write tests for it ATM (it's for a side project) 😢

@micheleb micheleb linked a pull request Aug 12, 2024 that will close this issue
@jkhusanov
Copy link
Collaborator

@micheleb could you provide a reproducible sample app?

@micheleb
Copy link
Author

Sure, I edited the example app so that it updates fillValue on button press. If you run it from this branch you'll see that the segment label is updated, but the cap never changes.

If you use this branch instead (which includes the commit from #104), the animation is run.

@Ray5055
Copy link

Ray5055 commented Dec 16, 2024

Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants