Shouldn't ignore/rsync options be merged instead?

[tomsseisums]

I required custom rsync options, and initially set up my config like:

shipit.initConfig({
  default: {
    /* .. */
    rsync: ['--no-p', '--no-o', '--no-g']
  }
})

Expecting the options to be passed, but actually here:

shipit/packages/shipit-cli/src/Shipit.js

Line 251 in 6ba6f00

const copyOptions = { ...defaultOptions, ...options }

Spread operator doesn't merge, but overrides.

Thankfully, shipit-deploy provides entry point to extend:

shipit/packages/shipit-deploy/src/tasks/deploy/update.js

Line 61 in 6ba6f00

const options = _.get(shipit.config, 'deploy.remoteCopy') || {

And yeah, changing my config to:

default: {
  deploy: {
    remoteCopy: {
      rsync: [/**/]
    }
  }
}

Works flawlessly!

Though! It seems to me, that copyOptions was intended to merge, instead of overwrite?

And in most cases it would, but since deploy.remoteCopy has a default, if I do not specify custom deploy.remoteCopy config, it uses the default ({ rsync: ['--del'] }), which, when spread in copyOptions would overwrite any rsync setting set in defaultOptions.