Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from FPDF to tc-lib-pdf #89

Open
ScreamingDev opened this issue Jun 5, 2017 · 2 comments
Open

Switch from FPDF to tc-lib-pdf #89

ScreamingDev opened this issue Jun 5, 2017 · 2 comments

Comments

@ScreamingDev
Copy link
Contributor

When creating labels via bulk action the API returns each one in its own PDF
which are merged into one using FPDF.
This old FPDF were replaced by TCPDF which itself again is no longer maintained for 2 years now (why we don't use it),
so we are stuck with some old package when we take GNU GPL in advantage.
This can be solved by the upcoming tc-lib-pdf which is the ancestor of TCPDF
and should be used as soon as it is released.

See https://github.com/tecnickcom/tc-lib-pdf
Currently has the license GNU GPL which also fits perfectly.

@mahype
Copy link
Contributor

mahype commented Jun 6, 2017

@sourcerer-mike Where is this FPDF From? From Woo or WordPress?

@andrecedik
Copy link
Contributor

Yeah, we've received the following message from a customer:

While testing to upgrade my site to PHP7 I got the following error for the Shipcloud Woocommerce integration.

FILE: /wp-content/plugins/shipcloud-for-woocommerce/vendor/setasign/fpdf/fpdf.php 
--------------------------------------------------------------------------------------------------------------------------- 
FOUND 1 ERROR AFFECTING 1 LINE 
--------------------------------------------------------------------------------------------------------------------------- 
1044 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0 
---------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/shipcloud-for-woocommerce/vendor/setasign/fpdf/makefont/makefont.php 
---------------------------------------------------------------------------------------------------------------------------------------- 
FOUND 1 ERROR AFFECTING 1 LINE 
---------------------------------------------------------------------------------------------------------------------------------------- 
388 | ERROR | Function set_magic_quotes_runtime() is deprecated since PHP 5.3 and removed since PHP 7.0 
----------------------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/shipcloud-for-woocommerce/vendor/setasign/fpdi/filters/FilterLZW.php 
---------------------------------------------------------------------------------------------------------------------------------------- 
FOUND 1 ERROR AFFECTING 1 LINE 
---------------------------------------------------------------------------------------------------------------------------------------- 
147 | ERROR | Bitwise shifts by negative number will throw an ArithmeticError in PHP 7.0 
-----------------------------------------------------------------------------------------------------------------------------------

So I think it's fair to say that we need a new solution for creating PDFs

@andrecedik andrecedik modified the milestones: 1.4.1, 1.5.0 Jul 20, 2017
@ScreamingDev ScreamingDev removed this from the 1.5.0 milestone Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants