Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External commands do no handle non ascii characters #69

Closed
jccomputing opened this issue Jun 25, 2014 · 2 comments
Closed

External commands do no handle non ascii characters #69

jccomputing opened this issue Jun 25, 2014 · 2 comments

Comments

@jccomputing
Copy link

Hello

The WebUI module exhibits the same problem as described in this issue: shinken-monitoring/mod-livestatus#27.

If we follow solution number one, the offending line is this one.

JCC
@mohierf
Copy link
Contributor

mohierf commented Aug 4, 2014

I think the problem is mainly due to the fact that the string is already UTF8 encoded. It is possible to ignore the decoding errors instead of trying to replace them. I will commit a fix for WebUI ...

mohierf pushed a commit that referenced this issue Aug 4, 2014
Fix #69: UTF8 encoding for external commands
59162bb
lermit pushed a commit to jetpulp/mod-webui that referenced this issue Nov 25, 2014
@lermit
Fix shinken-monitoring#69: UTF8 encoding for external commands
52d2de4
lermit pushed a commit to jetpulp/mod-webui that referenced this issue Feb 25, 2015
@lermit
Fix shinken-monitoring#69: UTF8 encoding for external commands
a2b87cd
@mohierf
Copy link
Contributor

mohierf commented Jun 18, 2015

See #141

@mohierf mohierf closed this as completed Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohierf @jccomputing