Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint and livestatus broker #32

Open
Seb-Solon opened this issue Aug 8, 2014 · 1 comment
Open

pylint and livestatus broker #32

Seb-Solon opened this issue Aug 8, 2014 · 1 comment

Comments

@Seb-Solon
Copy link
Contributor

Comes from shinken-solutions/shinken#549 :

While looking at pylint output for issue #373, i've found these 2 errors in livestatus :

  • The easy one, we have to remove the columns method, don't we ?
    shinken/modules/livestatus_broker/livestatus_query_metainfo.py:304: [E, LiveStatusQueryMetainfo.columns] An attribute affected in shinken.modules.livestatus_broker.livestatus_query_metainfo line 159 hide this method
  • The not too easy one. It's looks like livestatus haven't been updated with new filters methods
    shinken/modules/livestatus_broker/livestatus_wait_query.py:179: [E, LiveStatusWaitQuery.launch_query] No value passed for parameter 'cs' in function call

@gst
Copy link
Contributor

gst commented Apr 6, 2015

I gave a look at that..

first point seems now ok : I don't see any columns method in metainfo

second point : I don't see "cs" anymore in LiveStatusWaitQuery.launch_query signature..

we close ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants