Font style support #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-2
commented
Apr 23, 2020
| var fontStyleStr2:string = ""; | ||
| if (preserveFontStyle && fontStyle == `font-weight: bold`) | ||
| fontStyleStr2 += `\\bfseries`; | ||
| if (preserveFontStyle && fontStyle == `font-style: italic;`) |
There was a problem hiding this comment.
I don't know why only this comes with ; upstream
|
When shikijs/shiki#23 is merged we’ll merge this as well. Thanks for the good work 😃 |
The merge has come through a few days ago |
|
Awesome. I’ll get to it soon… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7
Experimental fix.
I originally thought that the different font-styles are not mutually exclusive, so I have designed the handling in that way. But I think the way this is implemented upstream in shiki it means that items can always only be bold or italic, right?
You originally suggested adding this to
fancyvrbOptions, but the property is perIThemedTokenso I added it in the loop.