Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declaring symbols as json_weak shouldn't be mandatory. #105

Open
xvln opened this issue Oct 7, 2024 · 1 comment
Open

Declaring symbols as json_weak shouldn't be mandatory. #105

xvln opened this issue Oct 7, 2024 · 1 comment

Comments

@xvln
Copy link

xvln commented Oct 7, 2024

It's pretty strange that this library defines all the weak symbols that it does. I can't think of a good reason for it, and I can think of many downsides... ideally there would be a way to turn that off, at the very least.

@sheredom
Copy link
Owner

sheredom commented Oct 7, 2024

Have you got a usecase where this affects you?

It's there so that it works as a single header (the alternative being doing what STB libs do and have a single C file you need to define an implementation macro in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants