Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra heatmap.2 arguments #2

Open
adomingues opened this issue Mar 8, 2018 · 1 comment
Open

Extra heatmap.2 arguments #2

adomingues opened this issue Mar 8, 2018 · 1 comment

Comments

@adomingues
Copy link

First of all thank you @lishen for this very useful package. I have one suggestion which I think would improve it further. Whilst the plots generated via drawHeatmap are good enough for internal presentations, the visualization could be improved for papers/presentations. For instance the labels are quite large in relation to the cells. Would it be possible to pass extra arguments to heatmap.2 in the function?

I am thinking something along the lines of:

setMethod(
    "drawHeatmap", "GeneOverlapMatrix",
    function(object, what=c("odds.ratio", "Jaccard"), log.scale=F, adj.p=F, 
             cutoff=.05, ncolused=9, grid.col=c("Greens", "Blues", "Greys", 
                                                "Oranges", "Purples", "Reds"),
note.col="red",
... # other arguments to be passed on to heatmap.2
) {
# (..)

heatmap.2(plot.mat, cellnote=note.mat, ...)

This would increase the flexibility of visualization immensely.

I guess the only other alternative would be for the user to extract the values using getMatrix(object) and then construct the plot from scratch.

Cheers.

@adomingues
Copy link
Author

Hi @lishen,

I wonder if you had a chance of looking into this issue.

Cheers,
António

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant