Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weird framebuffer issues after resizing. #8

Closed
TheNachoBIT opened this issue Jan 6, 2023 · 4 comments
Closed

Weird framebuffer issues after resizing. #8

TheNachoBIT opened this issue Jan 6, 2023 · 4 comments
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@TheNachoBIT
Copy link
Collaborator

Resizing the terminal can cause these kinds of issues.

imagen

This gets fixed when it goes from one entire window to another.
@HastagGuigui HastagGuigui added the bug Something isn't working label Jan 6, 2023
@HastagGuigui HastagGuigui added this to the 1.0.0 milestone Jan 6, 2023
@HastagGuigui HastagGuigui mentioned this issue Jan 6, 2023
Merged
22 tasks
@HastagGuigui
Copy link
Member

HastagGuigui commented Jan 7, 2023 •
edited
Loading

Fixed by clearing the screen every time the SIGWINCH signal is sent (aka the terminal is being resized), the only thing i need to fix is to add back the title screen logo once the screen has been cleared

Will be up next commit!

@HastagGuigui
Copy link
Member

wait, i just realised the way i took it is not compatible with windows

dammit

HastagGuigui added a commit that referenced this issue Jan 7, 2023
@HastagGuigui
Some bugfixes here and there
0feae4b 
- All: Removed lag on escape key
- Scoring: Fixed checksums not working properly. Scoring should now work perfectly fine.
- Util: Linux: Added support to the SIGWINCH signal, which clears the screen on terminal resize and prevents weird graphical issues
- Util: Windows: check_term_size() has been added to check if the window has been resized on platforms that do not support SIGWINCH (looking at you, Windows >:c)
^ Both points above fix #8

- Editor: Added playtest preview (SPACE)
- Editor: Added beatsounds
- Editor: Fixed text not rendering while typing
- Editor: Fixed #9, #10 and #12.
- Editor: Fixed saving straight up crashing
- Gameplay: Tried fixing offset issues
- Loading/Scores: Now checking for the chart's checksum and labels any scores who fail this check as "outdated"
@HastagGuigui
Copy link
Member

Found a workaround by checking for terminal size every loop cycle on Windows

@HastagGuigui HastagGuigui reopened this Jan 7, 2023
@HastagGuigui
Copy link
Member

ok im stupid and forgot since sigwinch doesn't exist on Windows it just crashes bru

HastagGuigui added a commit that referenced this issue Jan 7, 2023
@HastagGuigui
Minor bugfixes like windows crash
274a68e 
- Util: Checking if we're not using Windows to make sure SIGWINCH isn't checked for when it's not defined
- Loading/Options: Added placeholder values if some are not defined
- Loading/Scores: Making sure that it doesn't crash if there's no scores folder
- README: Reverted last commit, I managed to fix #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@TheNachoBIT @HastagGuigui