-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check framework with static analysis. #15
Comments
On my work: If it starts to grow further, with code, requirements, and complexity, I would raise a question to use Can I receive review once, if I send you my work, and so I improve my understanding and style of shell and compatibility? Please. It also going to help me and this refreshed installer to be accepted to Nix. |
Hmmm... interesting idea. I gave up on NixOS some time back, but incorporated some of their thinking into Libertine Linux. It might be worth taking the core ideas from shellfire and using them for an installer - for example, the checks in Libertine Linux is built from source (in practice, from sources versioned using git for maximum reproducibility) using shellfire and nothing else. Builds its own bootstrap toolchain, even. |
I going to check-out. I read about it, on your page and before. It is probably understandable why I involved in Nix Linux installation. Let's hope that everything there would move forward and now. BTW: this is my PR there: NixOS/nix#1565, if something. I am interested: Why you gave up? |
Koalaman still actively develops
shellcheck
.While website version not process amount of code of
shellfire
I installed
shellcheck
locally and:That way we can check any amount of code. It finds moments.
I find static code analysis the most pleasant thing. It reports, and you just sit and close all that moments overlooked in a minute a dozen.
And it gives links to explanations on why that check raised. It improved my shell style.
Despite Koalaman states on site that web static analysis services (CodeClimate and Codacy) has
shellcheck
, they probably dropped it. Because I checked-out and they not have shell supported now.Maybe I will crawl someday to embody
shellcheck
with TravisCI.The text was updated successfully, but these errors were encountered: