Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functions for prompt/message #13

Open
Anachron opened this issue Jan 21, 2015 · 3 comments
Open

Functions for prompt/message #13

Anachron opened this issue Jan 21, 2015 · 3 comments

Comments

@Anachron
Copy link

First off, I like this framework!
Secondly, I am missing functions like this:
https://github.com/Anachron/os-install/blob/master/new/helpers/shell.sh#L51
https://github.com/Anachron/os-install/blob/master/new/helpers/shell.sh#L16

Is it possible to make some functions for this too?

@raphaelcohn
Copy link
Member

Yes, it is. However, there would be some overlap with current functionality to tease out (eg terminal colouring). And the bashisms (eg [[) would need to be changed. Would it work best as another submodule, rather than being in core, do you think?

@Anachron
Copy link
Author

@raphaelcohn sure! Make it as sub-module, makes the most sense.
It's always good to have function for message, prompts and such things.

@raphaelcohn
Copy link
Member

Fancy having a go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants