Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cant close the menu on an official 7 inch touchscreen #13

Closed
CobreDev opened this issue Oct 25, 2018 · 7 comments · May be fixed by #19
Closed

Cant close the menu on an official 7 inch touchscreen #13

CobreDev opened this issue Oct 25, 2018 · 7 comments · May be fixed by #19

Comments

@CobreDev
Copy link

CobreDev commented Oct 25, 2018 •
edited
Loading

I can open the menu up and select stuff, but when I tap the close button, nothing happens. I can use it just fine if I plug a mouse into the pi.

My Hardware:

  • Raspberry Pi 3b+
  • The Official Raspberry Pi 7 Inch Touchscreen

Edit: When I move the mouse, it pops up, not when I click it. When I stop moving the mouse, it goes away after a little while.

Edit 2: If I turn touchscreen mode off, then I can close it by tapping the close button, then tapping off of the menu.
@CobreDev
Copy link
Author

CobreDev commented Oct 25, 2018 •
edited
Loading

So touchMode: true, or touchMode: false, doesn't really work well with a touchscreen

@shbatm
Copy link
Owner

shbatm commented Oct 26, 2018

Touchmode just changes if the labels are displayed or just appear on hover over. To close the menu on a touch screen try just touching somewhere off the menu.

@shbatm shbatm closed this as completed Oct 26, 2018
@shbatm shbatm reopened this Oct 26, 2018
@shbatm
Copy link
Owner

shbatm commented Nov 14, 2018

Closing due to inactivity.

@shbatm shbatm closed this as completed Nov 14, 2018
@Legion2
Copy link

Legion2 commented Mar 19, 2020

I have the same problem. To close the menu, two touch actions are required. First press the close button and then touch somewhere else, so the button loose the :hover state. The hover state does not really work on touch devices, because it's sticky and don't go away when you stop touching the button.

Would it be possible to disable the hover effect?

@shbatm
Copy link
Owner

shbatm commented Mar 19, 2020

Try the develop branch and then try commenting out these two lines with # and see if that improves anything. Not in a place I can test anything right now, sorry!

@Legion2 Legion2 mentioned this issue Mar 19, 2020
Open
@Legion2
Copy link

Legion2 commented Mar 19, 2020

@shbatm Commenting out these two line would completely break the menu html. I instead created a PR #19 which improves the touchscreen behavior, by removing the use of the :hover css selector and instead use the javascript callbacks.

@shbatm
Copy link
Owner

shbatm commented Mar 19, 2020

Sorry, been I while since I looked at that code and replied too quick--I really meant just commenting out the 2nd line to knock out the mouseover callbacks. I'll take a look at your PR when I get a chance, thanks for making the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved touchscreen menu control Legion2/MMM-OnScreenMenu
3 participants
@Legion2 @shbatm @CobreDev