Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing sys-info with sysinfo crate? #16

Closed
unlimitedsola opened this issue Dec 13, 2024 · 2 comments · Fixed by #17
Closed

Consider replacing sys-info with sysinfo crate? #16

unlimitedsola opened this issue Dec 13, 2024 · 2 comments · Fixed by #17

Comments

@unlimitedsola
Copy link
Contributor

unlimitedsola commented Dec 13, 2024

Rumors say cargo install bat is failing for some people due to a compilation failure from the sys-info crate. However the fix has not been merged for over half a year and the crate itself hasn't been active for over 2 years now.

There is an alternative crate sysinfo that's more regularly maintained and I believe it should provide similar functionality needed by this project.

Considering the replacement of the crate might change the output format a little, would love to hear your thoughts on this if I should proceed with a PR.

@unlimitedsola unlimitedsola changed the title Consider switching to sysinfo? Consider replacing sys-info with sysinfo crate? Dec 13, 2024
@sharkdp
Copy link
Owner

sharkdp commented Dec 27, 2024

Considering the replacement of the crate might change the output format a little, would love to hear your thoughts on this if I should proceed with a PR.

Sounds good, thank you.

@unlimitedsola
Copy link
Contributor Author

Sounds good, thank you.

@sharkdp Made two PRs for this: #18 updates the CI, #17 replaces the crate. Please take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants