Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme should be updated with working example #32

Open
michalzubkowicz opened this issue Jun 7, 2018 · 6 comments · May be fixed by #37
Open

Readme should be updated with working example #32

michalzubkowicz opened this issue Jun 7, 2018 · 6 comments · May be fixed by #37

Comments

@michalzubkowicz
Copy link

Example from Readme doesn't work properly with TypeScript.

It should be updated or have info about that all classess used by object mapper must be created with constructor or marked all fields as undefined
@artonio
Copy link
Contributor

artonio commented Jun 8, 2018

We use this in production so this library works in most cases, however it does not seem to be maintained. None of my pull requests are being reviewed :(

@shakilsiraj
Copy link
Owner

Sorry guys, I have been busy with other things .. didn't look at this for a while..

@artonio .. see release 1.6.0
@michalzubkowicz - that's a requirement for typescript and there are plenty of examples in the spec files.

@ghost
Copy link

ghost commented Aug 16, 2018 •
edited by ghost
Loading

Deserialization does not work. I got empty object. Default settings, angular 6 project. Serialization works properly.

@michalzubkowicz
Copy link
Author

@t-gawel-samsung , did you set all properties of object as undefined explictly?

@ghost
Copy link

ghost commented Aug 20, 2018

@michalzubkowicz yes, I finally found it is a fix. But this information is missing in the docs, or I just overlooked it?

@michalzubkowicz
Copy link
Author

@t-gawel-samsung - yes, it's missing in docs. It's in spec files, but nice would be to have it in example as I mentioned before.

@planser planser linked a pull request Jan 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initialize properties in deserialization example planser/json-object-mapper
3 participants
@michalzubkowicz @artonio @shakilsiraj