-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Bin Files #494
Comments
Sorry, I don't quite follow the part here
What do you mean around using binstubs for pre-compilation task? Would proposed approach literally move the code in binstub to some shakapacker/binstub file? What's the use case and benefit of adding extra code there rather than to the current generated binstub? |
The point is to make the binstub as compact as possible so that any customizations can be identified more easily. |
If we use the binstubs for a pre-compilation task, like always generating some files, then let's simplify and document the bin files.
The point is to make the binstub as compact as possible so that any customizations can be identified more easily.
Current bin file https://github.com/shakacode/shakapacker/blob/main/lib/install/bin/shakapacker has:
How about something like that is easier to read and modify?
And the same for the https://github.com/shakacode/shakapacker/blob/main/lib/install/bin/shakapacker-dev-server
The text was updated successfully, but these errors were encountered: