Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean output directory by default? #492

Open
justin808 opened this issue Jun 8, 2024 · 1 comment
Open

Clean output directory by default? #492

justin808 opened this issue Jun 8, 2024 · 1 comment

Comments

@justin808
Copy link
Member

justin808 commented Jun 8, 2024

Should bin/shakapacker and bin/shakapacker-dev-server clean the output directory when starting? should this be configurable in the shakapacker.yml file?

I see startup scripts like:

rm -rf public/packs/* && bundle exec rake react_on_rails:generate_packs && foreman start -f Procfile.dev

While this cleaning is not needed for docker builds, I don't see any harm.

Related to #491

@tomdracz
Copy link
Collaborator

IMO no. If one wants to clean up the compiled assets we have both clean and clobber tasks that can be used directly or enhancing the compile task.

From principle of least surprise standpoint, compilation or dev server having side effect of cleaning old assets, doesn't sit well with me also.

Are there any specific use cases where cleaning the output is really required? Don't think I've encountered many bar switching CDN config etc maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants