-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow build time when exceeding 20 fields in form #113
Comments
Hi @gv-sothebys-ivar, thanks for the report. The earlier version was implemented without involving code generation, and the current one is a ppx. That's unfortunate, but I won't be able to invest in this issue right now. Mainly due to being busy with relocation and the uncertainty of the future of PPXs in ReScript. Let's review this in a couple of months. |
We've also had to skip this library due to the PPX taking too long to do code gen. |
Hi,
I'm using Re-Formality version
4.0.0.-beta-17
and noticed when exceeding more than 20 fields the build times goes up exponentially. In my project I need up to 50 fields and for that case it just doesn't even build.I created a fresh project to test this, I only have one file implementing a simple form hook and added 20 fields to input, output and validate. I then added one field at a time to see the build time of the test project was growing and this was the result when reaching 25 fields:
Any idea why this is happening? I have used formality from earlier versions from you guys and I haven't had any problem with large forms before 🤔
I have added the test project as a zip so you can test this out for yourself
re-formality-test.zip
The text was updated successfully, but these errors were encountered: