From d5bc5cac3598bfecdbe1bbcf07b49144d8a4bd09 Mon Sep 17 00:00:00 2001
From: chris48s <chris48s@users.noreply.github.com>
Date: Sun, 18 Aug 2024 21:57:49 +0100
Subject: [PATCH] un-pin buildx version (#10453)

* un-pin buildx version

* convert stage name to lowercase

https://docs.docker.com/reference/build-checks/stage-name-casing/

* use key=value syntax

https://docs.docker.com/reference/build-checks/legacy-key-value-format/

* use JSON CMD format

https://docs.docker.com/reference/build-checks/json-args-recommended/
---
 .github/workflows/build-docker-image.yml  | 2 --
 .github/workflows/create-release.yml      | 2 --
 .github/workflows/publish-docker-next.yml | 2 --
 Dockerfile                                | 8 ++++----
 4 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml
index 1399c3f2b52ad..108841cb6a05c 100644
--- a/.github/workflows/build-docker-image.yml
+++ b/.github/workflows/build-docker-image.yml
@@ -14,8 +14,6 @@ jobs:
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-        with:
-          version: v0.9.1
 
       - name: Set Git Short SHA
         run: echo "SHORT_SHA=${GITHUB_SHA::7}" >> $GITHUB_ENV
diff --git a/.github/workflows/create-release.yml b/.github/workflows/create-release.yml
index f429d689e0a3d..88bae303e41ca 100644
--- a/.github/workflows/create-release.yml
+++ b/.github/workflows/create-release.yml
@@ -36,8 +36,6 @@ jobs:
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-        with:
-          version: v0.9.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v3
diff --git a/.github/workflows/publish-docker-next.yml b/.github/workflows/publish-docker-next.yml
index 994fc22b49eb8..7ea37682eac98 100644
--- a/.github/workflows/publish-docker-next.yml
+++ b/.github/workflows/publish-docker-next.yml
@@ -16,8 +16,6 @@ jobs:
 
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
-        with:
-          version: v0.9.1
 
       - name: Login to DockerHub
         uses: docker/login-action@v3
diff --git a/Dockerfile b/Dockerfile
index 4ecca5beeaa8e..d30fe2db54e35 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:20-alpine AS Builder
+FROM node:20-alpine AS builder
 
 RUN mkdir -p /usr/src/app
 RUN mkdir /usr/src/app/private
@@ -26,11 +26,11 @@ LABEL version=$version
 LABEL fly.version=$version
 
 # Run the server using production configs.
-ENV NODE_ENV production
+ENV NODE_ENV=production
 
 WORKDIR /usr/src/app
-COPY --from=Builder --chown=0:0 /usr/src/app /usr/src/app
+COPY --from=builder --chown=0:0 /usr/src/app /usr/src/app
 
-CMD node server
+CMD ["node", "server"]
 
 EXPOSE 80 443