Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default release isn't really 1 millisecond #57

Open
squinkylabs opened this issue Apr 19, 2021 · 10 comments
Open

the default release isn't really 1 millisecond #57

squinkylabs opened this issue Apr 19, 2021 · 10 comments

Comments

@squinkylabs
Copy link

the spec says default for ampeg_release is .001. But that sounds terrible. Is seems like a lot of SFZ don't specify ampeg_release. But they still sound ok because sforzando seems to default to something more like 20 milliseconds.

I know this "spec vs. sforzando" is an ancient issue, but this is a case where following the spec makes your player sound bad.

@kinwie
Copy link

kinwie commented Apr 19, 2021

It's 0.001. It have been checked here :
sfztools/sfizz#392

@squinkylabs
Copy link
Author

yes, that's what the spec says, but people author for the sforzando player, not the spec. The default for sforzando is what people author for. So, for example, I made a player, and made it follow the spec of .001 (one millisecond). So now it sounds bad because a lot of SFZ files don't have an ampeg_release override. I will update my player to be more like sforzando and not follow the spec.

I did notice (earlier) that the spec does mention this issue in "volume" where it says the spec is a max of +6 db but many players go much higher. That was useful information. Just suggesting similar info about ampeg_release would be useful to have in the spec.

@kinwie
Copy link

kinwie commented Apr 19, 2021

The original sfz v1 specs said it was 0 for default ampeg_release. I remember we had it corrected to 0.001 from the test result in rgc sfz player, DropZone and sforzando, also in sfizz. You can see the wav image result in the link above. There's a time ruler shows it is 0.001 s.

@squinkylabs
Copy link
Author

Ok. I don't believe you, though, because I know 1 ms is way to fast to prevent clicks. I measured sforz RTAS running in VCV host last night:

image

But that's ok. We don't have to agree.

@kinwie
Copy link

kinwie commented Apr 20, 2021

It's really default to 0.001 :)

@DSmolken
Copy link
Collaborator

We should try to get to the bottom of this. Can you both maybe check the following:

ampeg_release not set
ampeg_release=0.001
ampeg_release=0.02

That would let us know for certain whether the "not set" looks like 0.001 or like a larger value.

@jpcima
Copy link
Contributor

jpcima commented Apr 20, 2021

Sforzando's release default looks like 30ms
These two are matching on scope
<region> sample=*sine amp_veltrack=0 ampeg_release=0.03
<region> sample=*sine amp_veltrack=0

@squinkylabs
Copy link
Author

Yes, I will try to do a full comparison like @DSmolken suggests. Right know, I believe @jpcima's data more than mine. In the illo I pasted I'm sort of "eyeballing" "oh, looks like the releases ends here". Not very reliable for absolute numbers, esp when the definition is -85 db!

@kinwie
Copy link

kinwie commented Apr 20, 2021

Alright, I think Jpcima is correct. Just did a comparison again in sforzando. It is indeed 0.03

@DSmolken
Copy link
Collaborator

Confirmed, everybody seems to now agree that it's 0.03 in ARIA and 0.001 in rcg sfz and Cakewalk stuff. Sfizz will likely also update their default to this to match ARIA - will update ampeg_release again once they confirm that's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants