52 about hero section #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class attached to main should be added to the styling branch at some point as a default way to have consistent margins.
5 tasks
Hi Michael, your PR LGTM. The styling branch will be merged soon and we can then add the proper styling. Apologies for the lack of PR template, it has not been set up for this repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could not find the pull request template as mentioned in the notion. Hero section completed. It contains none of the proper styling from our styling guide (all just placeholder for the time being). The styling on the
element should be added to the layout.tsx or classed into the styling branch as a preset to make for easier page setup. @ChristopherFong604