CAN driver #66
Open
CAN driver #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrobren
reviewed
Aug 22, 2024
| can_message1 message_13; | ||
| can_message1 message_14; | ||
|
|
||
| message_10.id = id1; |
There was a problem hiding this comment.
Make messages 10 to 14 have global variable pointers, then initialize them in this function. We need to be able to access these CAN messages outside of the init function, and right now they'd be deleted at the end of it.
danrobren
reviewed
Aug 22, 2024
| */ | ||
|
|
||
| #include "can.h" | ||
| #include "can_driver.h" |
There was a problem hiding this comment.
Should be can_charger_driver.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the charger data sheet, implemented different CAN messages. There are some TODOs left. These include finding the actual charging current. The CAN_charging_driver is not completed yet (it is up to the reviewer's discretion to add it or not).