Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The zeros/roots of the spherical Hankel function of the second kind #195

Open
feima0011 opened this issue Oct 23, 2020 · 3 comments
Open

Comments

@feima0011
Copy link

https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m
find zero and root for the spherical Hankel function of the first kind.

However:
% The zeros/roots of the spherical Hankel function of the second kind
% can be obtained based on the following relationship.
% suppose z = x + iy is a zero for the spherical Hankel function of the first kind.
% then z = -ix + y, and z = -ix -y are zeros for the the spherical Hankel function of the second kind.

Please add this to the https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m

@hagenw
Copy link
Member

hagenw commented Oct 23, 2020

Thanks for commenting.
Do you propose to add the comment to the docstring of sphbesselh_zeros or where do you would expect it?

@feima0011
Copy link
Author

I want to add to the comments at the start of the file
https://github.com/sfstoolbox/sfs-matlab/blob/master/SFS_general/sphbesselh_zeros.m

but I do not have the right to make the modifications.

@hagenw
Copy link
Member

hagenw commented Oct 23, 2020

Thanks, I opened #196 to incorporate your changes.

Note, even if you don't have rights, you can always create a pull request from a fork, see:
https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants