First pass at improving *nix userdir handling #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4LT
reviewed
Jul 14, 2024
| /* note - we're specifically not using XDG_CONFIG_HOME here so we can match | ||
| * the behaviour of SDL_GetPrefPath() | ||
| */ | ||
| const char *env = getenv("XDG_DATA_HOME"); |
There was a problem hiding this comment.
I like that XDG paths are being employed, one less dot file/folder in $HOME. But should there be a fallback to $HOME/.quakespasm so as to not break current installations?
There was a problem hiding this comment.
Maybe it could check if there's an existing $HOME/.quakespasm folder and use that if so?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's built using SDL2, it will use the built-in functions
SDL_GetBasePath()andSDL_GetPrefPath(). Otherwise it will prefer~/.local/share/games/quake/or/usr/local/share/games/quake/for game data and~/.local/share/quakespasm/for configuration files.I've also reworked the desktop file and installation process in the makefile, as well as updated the Haiku code for userdirs.
quakespasm.svgattribution:Sasha Shor, Public domain, via Wikimedia Commons