Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negation in name #802

Open
romani opened this issue Feb 7, 2020 · 0 comments
Open

Negation in name #802

romani opened this issue Feb 7, 2020 · 0 comments

Comments

@romani
Copy link
Member

romani commented Feb 7, 2020

checkstyle/checkstyle#7529 (comment)

Usage of "not" is not very good if there is a way to use opposite word, it is ok especially if there is sibling method with positive name. In our case we do have such sibling method, so we will not force to use double negation.

I do not think there will be any maintenance costs for extra method, especially if we place them close to each other.

We spoke a lot about methods that starts with "no", I think we are ready to make Check on this in sevntu project, in config user need to be able to provide map of method sibling to skip violation on method that starts with negation.

We need to collect knowledge on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant