Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LineLengthExtendedCheck to log DetailAST #680

Open
rnveach opened this issue Jun 8, 2018 · 0 comments
Open

Update LineLengthExtendedCheck to log DetailAST #680

rnveach opened this issue Jun 8, 2018 · 0 comments
Labels
approved

Comments

@rnveach
Copy link
Contributor

rnveach commented Jun 8, 2018

Identified at #662 ,

LineLengthExtendedCheck needs to convert its log call from a line number to an AST since it is an AbstractCheck. Without this change, it can't support xpath suppression.

#662 (comment) explains why it is complicated to change.
@romani romani added the approved label Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romani @rnveach