Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of DetailAST.branchContains #669

Open
rnveach opened this issue May 27, 2018 · 2 comments
Open

Remove usage of DetailAST.branchContains #669

rnveach opened this issue May 27, 2018 · 2 comments
Labels
approved miscellaneous

Comments

@rnveach
Copy link
Contributor

rnveach commented May 27, 2018

Version of checkstyle/checkstyle#5124 for sevntu checks
rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue May 27, 2018
@rnveach
Issue sevntu-checkstyle#669: removed branchContains for modifiers
429a760
@rnveach rnveach mentioned this issue May 27, 2018
Merged
rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue May 27, 2018
@rnveach
Issue sevntu-checkstyle#669: removed branchContains for complicated c…
02cf172 
…ases (part 1)
@rnveach rnveach mentioned this issue May 27, 2018
Merged
romani pushed a commit that referenced this issue May 27, 2018
@rnveach @romani
Issue #669: removed branchContains for modifiers
a6a88d6
rnveach added a commit to rnveach/sevntu.checkstyle that referenced this issue May 27, 2018
@rnveach
Issue sevntu-checkstyle#669: removed branchContains for complicated c…
d6f3878 
…ases (part 1)
rnveach added a commit that referenced this issue May 28, 2018
@rnveach
Issue #669: removed branchContains for complicated cases (part 1)
3ca760e
kariem pushed a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018
@rnveach @kariem
Issue sevntu-checkstyle#669: removed branchContains for modifiers
655de55
kariem pushed a commit to kariem/sevntu.checkstyle that referenced this issue Jul 26, 2018
@rnveach @kariem
Issue sevntu-checkstyle#669: removed branchContains for complicated c…
ddb7bc5 
…ases (part 1)
@rnveach
Copy link
Contributor Author

rnveach commented Apr 7, 2019

4 checks still have the method
https://github.com/sevntu-checkstyle/sevntu.checkstyle/search?q=branchContains&unscoped_q=branchContains

@rnveach rnveach mentioned this issue Dec 31, 2019
Open
@nrmancuso nrmancuso mentioned this issue Apr 25, 2021
Closed
@nrmancuso
Copy link
Contributor

We can remove suppressions from #842 when this is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved miscellaneous
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rnveach @nrmancuso