-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discuss removing suppression for settersHaveSinceTag #1022
Comments
I think it is reasonable to add such tags to property setters anywhere really, let's see what others think. |
I don't believe this repo has those things documented, so it will be regression hunting to identify all the versions to add. The custom branch I used referenced in the main repo's issue should be able to be used for this. I am fine with this being done. |
This repo don't need this metadata for now, if we have time in future we will do this |
In checkstyle/checkstyle#13455 we add a
MatchXPath
check to ensure that all property setters have a@since
property in their Javadoc. For exampleIn #1023 we add a suppression for all checks in this repository because the CI in checkstyle repo is failing
https://checkstyle.semaphoreci.com/jobs/b80149c4-f163-4908-a4ab-98a19bcb625e
I am not sure if we want to add those
@since
s in this project or if it's possible. The purpose of this issue is to add anuntil ...
on the line above the suppression of this check and discuss potentially removing it in the futureThe text was updated successfully, but these errors were encountered: