Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve log formatting #397

Open
MMulthaupt opened this issue Dec 15, 2022 · 0 comments
Open

Improve log formatting #397

MMulthaupt opened this issue Dec 15, 2022 · 0 comments
Labels
quality Improve repurposability of the project without changing its behaviour user experience

Comments

@MMulthaupt
Copy link
Collaborator

MMulthaupt commented Dec 15, 2022

  1. Since some point during development logs made with Go's log package no longer get formatted correctly. The line number appears in front instead of at the end.
  2. A lot of logs point to log_limiter.go as the file making the log, which is not helpful.
  3. Context-cancellation as performed by reportWorkersResult() should explain why the context was cancelled.
  4. Any URLs being contacted should be logged directly, and the corresponding determined proxy URL should instead only be logged if it is different.
@MMulthaupt MMulthaupt added quality Improve repurposability of the project without changing its behaviour user experience labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Improve repurposability of the project without changing its behaviour user experience
Projects
None yet
Development

No branches or pull requests

1 participant