Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable update checks through deployment-config without requiring the bundle-info.json of each bundle #202

Open
dragetd opened this issue Nov 16, 2020 · 0 comments

Comments

@dragetd
Copy link
Member

dragetd commented Nov 16, 2020

Is your feature request related to a problem? Please describe.
Right now, each bundle update is check by checking its bundle-info.json. If we could check the update through deployment-config.json, trivrost would not have to go through every bundle-info.json.

Describe the solution you'd like
We could add the field 'signature' to the bundle-info.json which would hold the signature that is usally loaded from the bundleinfo-json.signature location.

We could design this in a backward-compatible way that trivrost first looks for a signature in the bundle-info.json and if not found, reverts to the old behavior. (this would imply that once configured, the .signature files are ignored, which is intended.)

trivrost would also have to locally save the existing .signature files (which it is not doing yet) and compare them to the read signature. The signature should be unique for each bundle like a checksum (@ma-assbrock hopefully can verify this). Then we could skip the bundle-info.json download and trivrost would also start a lot faster usually.

Feedback welcome!

@dragetd dragetd added this to the v1.5.0 milestone Nov 16, 2020
@dragetd dragetd modified the milestones: v1.5.0, trivrost-future Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant