Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installdown: version should be taken from launcher-config #175

Open
MMulthaupt opened this issue Sep 8, 2020 · 1 comment
Open

installdown: version should be taken from launcher-config #175

MMulthaupt opened this issue Sep 8, 2020 · 1 comment

Comments

@MMulthaupt
Copy link
Collaborator

MMulthaupt commented Sep 8, 2020

Installdown gets launcher info for embedding into MSI meta info from a variable determined during Makefile execution. The value is both incorrect and also not the one we want. It should be taken from launcher-config instead.

@dragetd
Copy link
Member

dragetd commented Sep 13, 2020

It defaults to the configured launcher-config (

"cmd/launcher/resources/launcher-config.json", "Path to a launcher-config for configuration.")
) and this is also passed in the makefile (
--launcher-config cmd/launcher/resources/launcher-config.json \
)

Could you explain what you mean? I do not see the problem.

@dragetd dragetd added this to the trivrost-future milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants