Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nameserver check fails if subdomain is not 'www' #36

Open
mejofi opened this issue Mar 15, 2024 · 0 comments
Open

nameserver check fails if subdomain is not 'www' #36

mejofi opened this issue Mar 15, 2024 · 0 comments

Comments

@mejofi
Copy link

mejofi commented Mar 15, 2024

It looks the ns_minimum_count check fails if a subdomain is used, and that subdomain is not 'www'. For example;

$ ready --check-filter=nameserver www.ur.nl
URL (no scheme): www.ur.nl, Domain (no path): www.ur.nl, Second Level Domain: ur.nl
[ OK ] At least two nameservers should be provided (['ur.nl.', 'fay.ns.cloudflare.com.', 'luke.ns.cloudflare.com.'])

$ ready --check-filter=nameserver e.ur.nl
URL (no scheme): e.ur.nl, Domain (no path): e.ur.nl, Second Level Domain: ur.nl
[FAIL] At least two nameservers should be provided (['web.flowmailer.net.'])

The value returned in the second example is the CNAME record, not the NS records for that subdomain, as none exist. It is technically possible that it could be delegated, so it is not a bad idea to check, but that should be for NS records specifically, with a fallback to the level above it.

The simplest solution would be to always check the second-level domain only, which is also what happens for the 'www' record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant