Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use objc2 more idiomatically #514

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jun 16, 2022

Follow-up of #513.

Breaking changes in cocoa and cocoa-foundation:

  • Methods now take and return bool instead of BOOL.
  • NSInteger is now isize, see detailed reasoning here.
  • Similar for NSUInteger/usize

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #508) made this pull request unmergeable. Please resolve the merge conflicts.

This now means that `NSInteger = isize` and `NSUInteger = usize`
Changes argument and return types that were previously BOOL to bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants