Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect item id in Inventory Route when using Forge + Spigot #41

Open
ATechAdventurer opened this issue Aug 24, 2020 · 2 comments
Open
Labels
bug Something isn't working

Comments

@ATechAdventurer
Copy link
Contributor

ATechAdventurer commented Aug 24, 2020

When using any forge + (bukkit/spigot/paper) environment (MCPC+, Cauldron, CatServer) the /player inventory route returns all items with minecraft: this is not correct.

The resolution to this problem requires a way to determine if an item is provided by a mod that is outside of vanilla Minecraft.

This is not a huge issue and will likely not be fixed because servertap does not support Forge server environments. But if a solution is possible it might be valuable to address this issue.

This is mostly just here for reference purposes.

@ATechAdventurer ATechAdventurer added the bug Something isn't working label Nov 24, 2020
@ItsViolet
Copy link

I do think this can be fixed by checking the 1st part of the colon separated name, and removing it if it equals minecraft. I will try to make a PR.

@zoeleu
Copy link
Contributor

zoeleu commented Sep 29, 2022

I don't believe it should be removed, as with Forge, items have different "providers" and in game it is already being referenced as minecraft:.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants