Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in documentation for 'made up keys' in Song Objects section #472

Open
aaronlutze opened this issue Sep 25, 2021 · 0 comments
Open
Assignees
Labels
Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated.

Comments

@aaronlutze
Copy link

Issue description

The word 'data-' is missing from the example to display custom data types from the song info object in the support documentation.

<span class="made-up-key" amplitude-song-info="made_up_key">

Environment

All

Steps to reproduce the issue

  1. Add a made up key to the song object
  2. To render the value of the made up key in your app, use the supplied code example from the docs of
    <span class="made-up-key" amplitude-song-info="made_up_key">
  3. Note that it doesn't render.

What is expected?

You need to add data- before amplitude-song-info in order to render.
<span class="made-up-key" **data-amplitude-song-info**="made_up_key"></span>

Link to where issue can be reproduced

https://521dimensions.com/open-source/amplitudejs/docs/configuration/song-objects.html#special-keys

@aaronlutze aaronlutze added the Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated. label Sep 25, 2021
@danpastori danpastori self-assigned this May 4, 2022
@danpastori danpastori moved this to Being Documented in AmplitudeJS 6.0 May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Needs Confirmation 🧐 Bugs that are reported, but needs to be confirmed and replicated.
Projects
Status: Being Documented
Development

No branches or pull requests

2 participants