Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD workflow to publish helm chart #450

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

robinson
Copy link

@robinson robinson commented Oct 30, 2024

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it: CI/CD flow to publish helm chart

Special notes for reviewers: need another step to publish into https://artifacthub.io/

Additional information (if needed):

@JBBianchi
Copy link
Member

Hi @robinson, thanks a lot for your PR !

But as you can see, it doesn't pass the DCO requirements. Could you please sign/verify and sign off your commits ?

Signed-off-by: lth <[email protected]>
@cdavernas cdavernas added priority: low Indicates a low priority issue weight: 2 An issue with a low development impact type: fix labels Oct 30, 2024
@cdavernas cdavernas added this to the v1.0.0 milestone Oct 30, 2024
@cdavernas cdavernas linked an issue Oct 30, 2024 that may be closed by this pull request
@cdavernas cdavernas added type: enhancement New feature or request runtime: kubernetes Concerns the Kubernetes runtime host and removed type: fix labels Oct 30, 2024
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cheers ❤️

version: 1.0.0-alpha5.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will we have to update this manually upon every release? If so, isn't there a way to automatize it using the CI pipeline?

Copy link
Author

@robinson robinson Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me making a test it with auto version based on the release.

Copy link
Author

@robinson robinson Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like not trivial :-) the most popular helm release strategey should be 1-1 versioning, that means, when new release taking place, simply creating a new version helm chart folder (refer: https://codefresh.io/docs/docs/ci-cd-guides/helm-best-practices/#simple-1-1-versioning) what do you think?

@JBBianchi
Copy link
Member

Btw, should this PR be merged in main or in gh-pages ?

Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
@robinson
Copy link
Author

Btw, should this PR be merged in main or in gh-pages ?

the gh-pages branch use to create a pages in order to publish the artifacts. The helm release workflow should be run in main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low Indicates a low priority issue runtime: kubernetes Concerns the Kubernetes runtime host type: enhancement New feature or request weight: 2 An issue with a low development impact
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add CI/CD workflow to package Helm charts
3 participants