-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD workflow to publish helm chart #450
base: main
Are you sure you want to change the base?
Conversation
Hi @robinson, thanks a lot for your PR ! But as you can see, it doesn't pass the DCO requirements. Could you please sign/verify and sign off your commits ? |
Signed-off-by: lth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cheers ❤️
deployments/helm/Chart.yaml
Outdated
version: 1.0.0-alpha5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will we have to update this manually upon every release? If so, isn't there a way to automatize it using the CI pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me making a test it with auto version based on the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like not trivial :-) the most popular helm release strategey should be 1-1 versioning, that means, when new release taking place, simply creating a new version helm chart folder (refer: https://codefresh.io/docs/docs/ci-cd-guides/helm-best-practices/#simple-1-1-versioning) what do you think?
Btw, should this PR be merged in main or in gh-pages ? |
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
Signed-off-by: lth <[email protected]>
the gh-pages branch use to create a pages in order to publish the artifacts. The helm release workflow should be run in main branch. |
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it: CI/CD flow to publish helm chart
Special notes for reviewers: need another step to publish into https://artifacthub.io/
Additional information (if needed):