Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proper environement variables isolation (AWS SDK v2 import is affected) #148

Open
medikoo opened this issue Dec 28, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@medikoo
Copy link
Contributor

medikoo commented Dec 28, 2022

Currently, all we do, is that we ensure that the state of environment variables is reset between test file runs. Some tests have isolation ensured either by internally using overrideEnv util or if they're based on runServerless.

Still, it appears that in AWS SDK v2 case, the existence of AWS_SDK_LOAD_CONFIG env variable may force tests to fail, as then AWS SDK on imports unconditionally assumes the existence of .aws folder, and as the home directory is redirected to an empty temp directory, it ends with failure (see serverless/serverless#11636 (comment)).

Ideally such errors should not surface

@medikoo medikoo added the enhancement New feature or request label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant